chore: run integ tests against flutter beta #4030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
changed the title
Equartey
previously approved these changes
Nov 2, 2023
NikaHsn
reviewed
Nov 2, 2023
.github/workflows/e2e_windows.yaml
Outdated
Comment on lines
32
to
33
| - channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }} | ||
|
|
There was a problem hiding this comment.
I'm not sure if my suggestion is correct or not but I think the value for - channel: should be either 'beta', 'stable' or 'NONE' and so the code to be:
Suggested change
| - channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }} | |
| - channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example') && 'beta' || 'NONE' }} |
or
Suggested change
| - channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }} | |
| - channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example') | ternary ('beta', 'NONE') }} |
There was a problem hiding this comment.
In this case it should be the same thing.
(true && 'beta') || 'NONE== 'beta'(true) && 'beta' || 'NONE'== 'beta'(false && 'beta') || 'NONE== 'NONE'(false) && 'beta' || 'NONE'== 'NONE'
Equartey
approved these changes
Nov 3, 2023
NikaHsn
approved these changes
Nov 3, 2023
NikaHsn
pushed a commit
that referenced
this pull request
Dec 5, 2023
* chore: run integ tests on beta * chore: pass channel to install dependencies * chore: update input to use correct param * chore: update all platforms * chore: skip tests for beta on PRs * chore: run auth tests against beta only * chore: fix env vars * chore fix env usage * chore: run auth tests against stable * chore: test removing IS_AUTH_PACKAGE * chore: remove env vars for ios tests * chore: remove changes to non ios platforms * chore: fix package names * chore: update remaining platforms * chore: only run auth tests against beta
NikaHsn
pushed a commit
that referenced
this pull request
Dec 6, 2023
* chore: run integ tests on beta * chore: pass channel to install dependencies * chore: update input to use correct param * chore: update all platforms * chore: skip tests for beta on PRs * chore: run auth tests against beta only * chore: fix env vars * chore fix env usage * chore: run auth tests against stable * chore: test removing IS_AUTH_PACKAGE * chore: remove env vars for ios tests * chore: remove changes to non ios platforms * chore: fix package names * chore: update remaining platforms * chore: only run auth tests against beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.