Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run integ tests against flutter beta #4030

Merged
merged 15 commits into from
Nov 3, 2023
Merged

chore: run integ tests against flutter beta #4030

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c79e210
chore: run integ tests on beta
Jordan-Nelson Oct 30, 2023
b8660a7
chore: pass channel to install dependencies
Jordan-Nelson Oct 31, 2023
362fad7
chore: update input to use correct param
Jordan-Nelson Oct 31, 2023
fe1b0b4
chore: update all platforms
Jordan-Nelson Oct 31, 2023
00bc15e
chore: skip tests for beta on PRs
Jordan-Nelson Nov 1, 2023
d4f6931
chore: run auth tests against beta only
Jordan-Nelson Nov 1, 2023
5a8f331
chore: fix env vars
Jordan-Nelson Nov 1, 2023
ba24c5c
chore fix env usage
Jordan-Nelson Nov 1, 2023
160455b
chore: run auth tests against stable
Jordan-Nelson Nov 1, 2023
63af299
chore: test removing IS_AUTH_PACKAGE
Jordan-Nelson Nov 1, 2023
9a23eaf
chore: remove env vars for ios tests
Jordan-Nelson Nov 2, 2023
21cf0c0
chore: remove changes to non ios platforms
Jordan-Nelson Nov 2, 2023
c16adaf
chore: fix package names
Jordan-Nelson Nov 2, 2023
9b705f0
chore: update remaining platforms
Jordan-Nelson Nov 2, 2023
b9457dc
chore: only run auth tests against beta
Jordan-Nelson Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/e2e_android.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ jobs:
api-level:
- 24
- 33
channel:
- "beta"
- "stable"
# Skips e2e tests against beta on PRs, except for auth/authenticator
# Todo(Jordan-Nelson): Update tests to skip beta for auth once flutter 3.16.0 becomes stable.
exclude:
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}

steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # 3.5.3
with:
Expand All @@ -43,6 +51,8 @@ jobs:

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
with:
channel: ${{ matrix.channel }}

- name: Pub Upgrade
run: aft exec --include=${{ inputs.package-name }} -- flutter pub upgrade
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/e2e_ios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@ on:
jobs:
e2e-test-ios:
runs-on: macos-latest-xl
strategy:
# Allows other matrix items to run if one fails
fail-fast: false
matrix:
channel:
- "beta"
- "stable"
# Skips e2e tests against beta on PRs, except for auth/authenticator
# Todo(Jordan-Nelson): Update tests to skip beta for auth once flutter 3.16.0 becomes stable.
exclude:
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}

# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
Expand All @@ -30,6 +42,8 @@ jobs:

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
with:
channel: ${{ matrix.channel }}

- name: Launch iOS simulator
uses: ./.github/composite_actions/launch_ios_simulator
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/e2e_linux.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ jobs:
e2e-test-linux:
runs-on:
labels: amplify-flutter_ubuntu-latest_4-core
strategy:
# Allows other matrix items to run if one fails
fail-fast: false
matrix:
channel:
- "beta"
- "stable"
# Skips e2e tests against beta on PRs, except for auth/authenticator
# Todo(Jordan-Nelson): Update tests to skip beta for auth once flutter 3.16.0 becomes stable.
exclude:
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}

# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
Expand All @@ -31,6 +43,8 @@ jobs:

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
with:
channel: ${{ matrix.channel }}

- name: Pub Upgrade
run: aft exec --include=${{ inputs.package-name }} -- flutter pub upgrade
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/e2e_web.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ jobs:
e2e-test-web:
runs-on:
labels: amplify-flutter_ubuntu-latest_4-core
strategy:
# Allows other matrix items to run if one fails
fail-fast: false
matrix:
channel:
- "beta"
- "stable"
# Skips e2e tests against beta on PRs, except for auth/authenticator
# Todo(Jordan-Nelson): Update tests to skip beta for auth once flutter 3.16.0 becomes stable.
exclude:
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}

# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
Expand All @@ -31,6 +43,8 @@ jobs:

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
with:
channel: ${{ matrix.channel }}

- name: Pub Upgrade
run: aft exec --include=${{ inputs.package-name }} -- flutter pub upgrade
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/e2e_windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ jobs:
e2e-test-windows:
runs-on:
labels: amplify-flutter_windows-latest_8-core
strategy:
# Allows other matrix items to run if one fails
fail-fast: false
matrix:
channel:
- "beta"
- "stable"
Jordan-Nelson marked this conversation as resolved.
Show resolved Hide resolved
# Skips e2e tests against beta on PRs, except for auth/authenticator
# Todo(Jordan-Nelson): Update tests to skip beta for auth once flutter 3.16.0 becomes stable.
exclude:
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}

Copy link
Member

@NikaHsn NikaHsn Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if my suggestion is correct or not but I think the value for - channel: should be either 'beta', 'stable' or 'NONE' and so the code to be:

Suggested change
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example') && 'beta' || 'NONE' }}

or

Suggested change
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example' && 'beta') || 'NONE' }}
- channel: ${{ (github.event_name == 'pull_request' && inputs.package-name != 'amplify_auth_cognito_example' && inputs.package-name != 'amplify_authenticator_example') | ternary ('beta', 'NONE') }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it should be the same thing.

  • (true && 'beta') || 'NONE == 'beta'
  • (true) && 'beta' || 'NONE' == 'beta'
  • (false && 'beta') || 'NONE == 'NONE'
  • (false) && 'beta' || 'NONE' == 'NONE'

# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write
Expand All @@ -34,6 +46,8 @@ jobs:

- name: Install dependencies
uses: ./.github/composite_actions/install_dependencies
with:
channel: ${{ matrix.channel }}

- name: Pub Upgrade
run: dart pub global run aft exec --include=${{ inputs.package-name }} -- flutter pub upgrade
Expand Down
Loading