Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): forget local device only if matches #4060

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix(auth): forget local device only if matches #4060

merged 4 commits into from
Jan 23, 2024

Conversation

dtodt
Copy link
Contributor

@dtodt dtodt commented Nov 3, 2023 •
edited
Loading

Issue #4056 :

Description of changes:

  • forgetDevice only removes the local device if matches;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dtodt dtodt requested a review from a team as a code owner November 3, 2023 11:17
This was referenced Nov 3, 2023
Open
Closed
Closed
@Jordan-Nelson Jordan-Nelson mentioned this pull request Jan 22, 2024
Closed
Jordan-Nelson
Jordan-Nelson previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Jordan-Nelson Jordan-Nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. I pulled this down and verified this resolves the issue. I will get someone else to review this and then merge it.

Equartey
Equartey previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Equartey Equartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@Jordan-Nelson Jordan-Nelson dismissed stale reviews from Equartey and themself via bb12122 January 23, 2024 19:37
Equartey
Equartey approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Equartey Equartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests, LGTM.

@Jordan-Nelson Jordan-Nelson merged commit 05f0fc8 into aws-amplify:main Jan 23, 2024
116 of 146 checks passed
NikaHsn pushed a commit that referenced this pull request Jan 26, 2024
@dtodt @Jordan-Nelson
fix(auth): forget local device only if matches (#4060)
96f3a06 
* fix(auth): forget local device only if matches

* chore: add unit tests for remove local device

---------

Co-authored-by: Jordan Nelson <nejrd@amazon.com>
Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
NikaHsn pushed a commit that referenced this pull request Jan 26, 2024
chore(version): Bump version
e7ab0ba 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=60.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))
@NikaHsn NikaHsn mentioned this pull request Jan 26, 2024
Merged
NikaHsn pushed a commit that referenced this pull request Jan 27, 2024
chore(version): Bump version
9003cf2 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 30, 2024
chore(version): Bump version
da27fe0 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=5.0.1"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 31, 2024
chore(version): Bump version
1e5bd17 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 31, 2024
chore(version): Bump version
186912c 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
@dtodt @Jordan-Nelson @NikaHsn
fix(auth): forget local device only if matches (#4060)
4e92cef 
* fix(auth): forget local device only if matches

* chore: add unit tests for remove local device

---------

Co-authored-by: Jordan Nelson <nejrd@amazon.com>
Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
@NikaHsn
chore(version): Bump version
77a175d 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
chore(version): Bump version
692d045 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@NikaHsn NikaHsn mentioned this pull request Feb 1, 2024
Merged
NikaHsn pushed a commit that referenced this pull request Feb 5, 2024
@NikaHsn
chore(version): Bump version
a4bb296 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordan-Nelson Jordan-Nelson Jordan-Nelson approved these changes

@Equartey Equartey Equartey approved these changes

Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtodt @Equartey @Jordan-Nelson