Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uncaught exception in smithy code #4369

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: uncaught exception in smithy code #4369

merged 1 commit into from
Jan 22, 2024

Conversation

Jordan-Nelson
Copy link
Member

Issue #, if available: #4345

Description of changes:

  • Replace rethrow/catchError(completer.completeError) with return completer.completeError(e)
  • Remove a previous fix that was put in place for this that is no longer required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner January 19, 2024 19:28
Equartey
Equartey approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Equartey Equartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works! Nice find.

@Jordan-Nelson Jordan-Nelson merged commit ec2ddbf into main Jan 22, 2024
295 checks passed
@Jordan-Nelson Jordan-Nelson deleted the fix/smithy-uncaught-exception branch January 22, 2024 17:20
NikaHsn pushed a commit that referenced this pull request Jan 26, 2024
@Jordan-Nelson
fix: uncaught exception in smithy code (#4369)
573ae0c
NikaHsn pushed a commit that referenced this pull request Jan 26, 2024
chore(version): Bump version
e7ab0ba 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=60.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))
@NikaHsn NikaHsn mentioned this pull request Jan 26, 2024
Merged
NikaHsn pushed a commit that referenced this pull request Jan 27, 2024
chore(version): Bump version
9003cf2 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 30, 2024
chore(version): Bump version
da27fe0 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=5.0.1"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 31, 2024
chore(version): Bump version
1e5bd17 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Jan 31, 2024
chore(version): Bump version
186912c 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
@Jordan-Nelson @NikaHsn
fix: uncaught exception in smithy code (#4369)
623a067
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
@NikaHsn
chore(version): Bump version
77a175d 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
NikaHsn pushed a commit that referenced this pull request Feb 1, 2024
chore(version): Bump version
692d045 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
@NikaHsn NikaHsn mentioned this pull request Feb 1, 2024
Merged
NikaHsn pushed a commit that referenced this pull request Feb 5, 2024
@NikaHsn
chore(version): Bump version
a4bb296 
### Fixes
- fix(auth): forget local device only if matches ([#4060](#4060))
- fix: Bumped built_value to ">=8.6.0 <8.9.0" and built_value_generator to 8.8.1
- fix: Bumped drift to ">=2.14.0 <2.15.0" and drift_dev to ">=2.14.0 <2.15.0".
- fix: Bumped package_info_plus to ">=4.0.1 <=6.0.0"
- fix: Bumped path to ">=1.8.0 <2.0.0"
- fix: uncaught exception in smithy code ([#4369](#4369))

Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikaHsn NikaHsn NikaHsn approved these changes

@Equartey Equartey Equartey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jordan-Nelson @Equartey @NikaHsn