-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to community edition of AsyncStorage for React Native #4402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
Codecov Report
@@ Coverage Diff @@
## native-60 #4402 +/- ##
==========================================
Coverage 78.72% 78.72%
==========================================
Files 165 165
Lines 9032 9032
Branches 1820 1820
==========================================
Hits 7110 7110
Misses 1789 1789
Partials 133 133 Continue to review full report at Codecov.
|
@Amplifiyer @haverchuck Too many people are having issues with sessions due to latest broken push including #4380 #3991 |
Thanks @Ashish5591 While i have already implemented custom storage for auth package it looks like there seems to be an unstable behavior of session. Spent couple days trying to figure out the root of problem but haven't had any luck. |
Sorry, I notice this is merged to aws-amplify:native-60, but why I cannot see the changes on https://github.com/aws-amplify/amplify-js/tree/native-60 |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #:
fixes: #4351
fixes: #4272
Description of changes:
Migrating to community edition of AsyncStorage for React Native
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.