Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate .prettierrc & .prettierignore #7790

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

iartemiev
Copy link
Member

Delete .prettier config files from subdirectories. Consolidate rules in the root config files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev added the Tooling Related to Tooling label Feb 21, 2021
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #7790 (feefdeb) into main (c0ab2dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7790   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files         215      215           
  Lines       13450    13450           
  Branches     2641     2641           
=======================================
  Hits         9971     9971           
  Misses       3280     3280           
  Partials      199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ab2dd...feefdeb. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@iartemiev iartemiev merged commit 0267dc5 into aws-amplify:main Feb 22, 2021
@@ -1,11 +0,0 @@
module.exports = {
printWidth: 120,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late of a comment, but do we want to consider moving this to the root config? And can we follow this up with local prettier runs?

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Tooling Related to Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants