chore(@aws-amplify/ui-components): Local prettier run on ui-components #8136
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8136 +/- ##
=======================================
Coverage 75.58% 75.58%
=======================================
Files 215 215
Lines 13592 13592
Branches 2676 2676
=======================================
Hits 10273 10273
Misses 3117 3117
Partials 202 202 Continue to review full report at Codecov.
|
| '@typescript-eslint/no-empty-function': 0, | ||
| '@typescript-eslint/ban-ts-comment': 0, | ||
| '@typescript-eslint/ban-types': 0, | ||
| '@stencil/decorators-style': 0 |
There was a problem hiding this comment.
This is the only code change made. With printwidth reduced from 120 to 80, decorators were moved to newlines which eslint didn't like. I disabled the rule here ('@stencil/decorators-style': 0).
| @@ -47,7 +47,7 @@ | |||
| }, | |||
| { | |||
| "path": "dist/withSSRContext+Storage.js.min.js", | |||
| "maxSize": "181kB" | |||
There was a problem hiding this comment.
One more file with actual code change! 😛 Bumping this to 190 kB as discussed internally.
| @@ -43,11 +43,11 @@ | |||
| }, | |||
| { | |||
| "path": "dist/withSSRContext.js.min.js", | |||
| "maxSize": "146kB" | |||
| "maxSize": "155kB" | |||
There was a problem hiding this comment.
Increasing this to 155kB as well (+9 kB), which have been failing recently as well
There was a problem hiding this comment.
Out of curiosity was there a reason that we chose +9 kB and is that likely to need to change again?
There was a problem hiding this comment.
No particular reason for +9kB. But the goal is that this should be small enough to catch unusually high increase in bundle size. This will need to be changed again eventually as our bundle size creeps up little by little, which I'm okay with as long as we're capable of catching unusual bundle size increase.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
This is a follow-up to #7790, which consolidated
prettierrcat the root. The prettier changes haven't been applied to ui-components files yet, so this pr runs prettier on them. Submitting this so that future UI Components PR are free of unrelated style changes.Issue #, if available
Description of how you validated changes
yarn testandeslintpassed. The only code change was disabling an eslint rule that forcesdecoratorsto be inline with the variable. See comment below.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.