Setup prettier to run on pre-commit #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiekeller
approved these changes
Jul 14, 2021
wlee221
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
LGTM! I assume 1321332 is the only meaningful code change here.
ps. @eddiekeller this reminds me of a similar pr i made, but more intimidating 😆 aws-amplify/amplify-js#8136
ericclemmons
approved these changes
Jul 15, 2021
| @@ -0,0 +1 @@ | |||
| _ | |||
There was a problem hiding this comment.
It's an internal husky folder
Comment on lines
+1
to
+2
| .next | ||
| .husky |
There was a problem hiding this comment.
Does prettier not automatically ignore what's in .gitignore? I assumed it did. TIL!
There was a problem hiding this comment.
Apparently not, it was trying to lint the .next folder
Yup, the first commit is the real change. Second is just running prettier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR sets up Prettier to run on the pre-commit git hook (will run prettier on staged files right before being committed). I went with
huskyandlint-stagedto runprettierbecauselint-stagedworks with ESLint which I will add in the next PR. I've also prettier-ified the entire repo. If anyone has objections to running prettier on the whole repo as opposed to running it as we change things, please let me know.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.