Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add url to docs site for version upgrades #8083

Merged
merged 8 commits into from
Apr 15, 2021

Conversation

manueliglesias
Copy link
Contributor

Description of changes

Added url to github issue template for bugs.
Not to be merged before aws-amplify/docs#3135

Issue #, if available

aws-amplify/docs#3135

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Added url to  github issue template for bugs
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #8083 (80765dc) into main (c1ce5ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8083   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files         215      215           
  Lines       13571    13571           
  Branches     2675     2675           
=======================================
  Hits        10250    10250           
  Misses       3118     3118           
  Partials      203      203           
Impacted Files Coverage Δ
packages/auth/src/Errors.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ce5ac...80765dc. Read the comment docs.

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the improvement @manueliglesias. I just got some minor nits.

packages/auth/src/Errors.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @manueliglesias

Copy link

@agileurbanite agileurbanite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@codecov-io
Copy link

Codecov Report

Merging #8083 (369b637) into main (a15b8f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8083   +/-   ##
=======================================
  Coverage   75.57%   75.57%           
=======================================
  Files         215      215           
  Lines       13591    13591           
  Branches     2676     2676           
=======================================
  Hits        10272    10272           
  Misses       3117     3117           
  Partials      202      202           
Impacted Files Coverage Δ
packages/auth/src/Errors.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15b8f0...369b637. Read the comment docs.

@manueliglesias manueliglesias merged commit a664adb into aws-amplify:main Apr 15, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants