Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for duplicate-packages integ tests #8217

Merged
merged 3 commits into from
May 4, 2021
Merged

Add configuration for duplicate-packages integ tests #8217

merged 3 commits into from
May 4, 2021

Conversation

slaymance
Copy link
Contributor

Description of changes

Configures CircleCI to run new integration tests used to capture various errors caused by duplicate packages. Please see docs PR 3215 and js PR 8083 for documentation regarding this error.

Issue #, if available

docs PR 3215
js PR 8083

Description of how you validated changes

Ran an integration test workflow in our CircleCI pipeline to ensure config changes properly run the duplicate-packages Cypress tests:
https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/7763/workflows/8240bb12-7cca-49eb-9c9f-9890116371cc

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@slaymance slaymance added the config Any configuration issues label May 3, 2021
@slaymance slaymance self-assigned this May 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #8217 (4e8c0cd) into main (89a2250) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8217   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files         233      233           
  Lines       16283    16283           
  Branches     3475     3475           
=======================================
  Hits        12662    12662           
  Misses       3514     3514           
  Partials      107      107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a2250...4e8c0cd. Read the comment docs.

.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@github-actions
Copy link

github-actions bot commented May 5, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config Any configuration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants