fix(api): Add User-Agent and intercept subscription connect request #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
commented
Jan 19, 2023
Comment on lines
+94
to
+108
| urlRequest.setValue(AWSAPIPluginsCore.baseUserAgent(), | ||
| forHTTPHeaderField: URLRequestConstants.Header.userAgent) | ||
|
|
||
| // Intercept the request | ||
| for interceptor in requestInterceptors { | ||
| do { | ||
| urlRequest = try await interceptor.intercept(urlRequest) | ||
| } catch let error as APIError { | ||
| fail(error) | ||
| return | ||
| } catch { | ||
| fail(APIError.unknown("Could not validate request", "", nil)) | ||
| return | ||
| } | ||
| } |
|
This PR is no longer required, see #2683 for latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
Add User-Agent to the underlying URLRequest for subscriptions. This change depends on AppSyncRTClient 3.0.0 with aws-amplify/aws-appsync-realtime-client-ios#110
This change is in
v2and will need another PR forv1. AppSync SDK should also eventually consume AppSyncRTClient 3.0.0.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.