feat: pass URLRequest instead of URL to interfaces #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
5d
reviewed
Jan 19, 2023
...RealTimeClient/ConnectionProvider/AppsyncRealtimeConnection/RealtimeConnectionProvider.swift
Show resolved
Hide resolved
...RealTimeClient/ConnectionProvider/AppsyncRealtimeConnection/RealtimeConnectionProvider.swift
Show resolved
Hide resolved
|
Integ tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
These are some changes necessary to allow passing in a URLRequest instead of URL. Because of the change, this will be released as a major version bump v3.0.0.
Integration Testing
Swift Package doesn't have the integration test target, which makes sense since we do not produce it as a product for customers. Had to run
pod installand open the xcworkspace to access the integration test target.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.