Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(predictions): resolve swiftformat errors and warnings #3851

Merged

Conversation

phantumcode
Copy link
Contributor

Issue #

Description

Resolving SwiftFormat errors and warnings for the Predictions plugin.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner September 3, 2024 18:17
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 19.71831% with 57 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (ca6c65a) to head (bcab1d7).
Report is 8 commits behind head on chore/resolve_swiftformat.

Files with missing lines Patch % Lines
...gin/Support/Utils/IdentifyResultTransformers.swift 0.00% 7 Missing ⚠️
...Support/Utils/IdentifyTextResultTransformers.swift 0.00% 7 Missing ⚠️
...s/IdentifyTextResultTransformers+KeyValueSet.swift 0.00% 6 Missing ⚠️
...ictionsPlugin/Support/PredictionsAWSServices.swift 0.00% 5 Missing ⚠️
...sPlugin/Liveness/Service/FaceLivenessSession.swift 0.00% 4 Missing ⚠️
...ort/Utils/IdentifyEntitiesResultTransformers.swift 0.00% 4 Missing ⚠️
.../Utils/IdentifyTextResultTransformers+Tables.swift 0.00% 4 Missing ⚠️
...gin/Dependency/AWSTranscribeStreamingAdapter.swift 0.00% 2 Missing ⚠️
...in/Service/MultiService/IdentifyMultiService.swift 0.00% 2 Missing ⚠️
...rvice/MultiService/InterpretTextMultiService.swift 0.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@                      Coverage Diff                      @@
##           chore/resolve_swiftformat    #3851      +/-   ##
=============================================================
+ Coverage                      68.51%   68.69%   +0.18%     
=============================================================
  Files                           1080     1080              
  Lines                          37608    37622      +14     
=============================================================
+ Hits                           25766    25844      +78     
+ Misses                         11842    11778      -64     
Flag Coverage Δ
API_plugin_unit_test 68.96% <ø> (ø)
AWSPluginsCore 68.56% <ø> (ø)
Amplify 47.62% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 84.52% <ø> (ø)
Auth_plugin_unit_test 79.71% <ø> (+0.03%) ⬆️
DataStore_plugin_unit_test 82.23% <ø> (+1.01%) ⬆️
Geo_plugin_unit_test 72.00% <ø> (ø)
Logging_plugin_unit_test 62.95% <ø> (ø)
Predictions_plugin_unit_test 37.19% <19.71%> (-0.14%) ⬇️
PushNotifications_plugin_unit_test 86.21% <ø> (ø)
Storage_plugin_unit_test 76.81% <ø> (ø)
unit_tests 68.69% <19.71%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit 6c28586 into chore/resolve_swiftformat Oct 11, 2024
70 checks passed
@phantumcode phantumcode deleted the chore/resolve_swiftformat_predictions branch October 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants