Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolving swift formatting errors #3906

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Oct 24, 2024

Issue #

Description

Merging previously reviewed and approved code changes to resolve swift formatting errors and warnings:

Updates were made that weren't previously reviewed can be seen from this commit: f944c94

Swift linting failure is expected due to formatting changes impacting code with pre-existing lint errors that have not been resolved. This can be ignored, considered out of scope of formatting changes.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…le (#3843)

* resolve swiftformat errors and warnings

* resolve review comments

* move braces back to same-line

* fix argument spacing
* chore(analytics): resolve swiftformat errors and warnings

* chore(analytics): resolve swiftformat errors and warnings

* resolve review comments

* fix build errors
* chore(notifications): resolve swiftformat errors and warnings

* updated swiftformat rules
* chore(datastore): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* update rules

* fix build error

* fix brace alignment
* chore(api): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* update rules
* chore(logging): resolve swiftformat errors and warnings

* updated swiftformat rules
* chore(geo): resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
* chore(predictions): resolve swiftformat errors and warnings

* updated swiftformat rules

* remove duplicate import statement
* chore(core): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* fix build error

* update rules
* chore: resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
* chore(storage): resolve swiftformat errors and warnings

* updated swiftformat rules

* update rules
* chore(auth): resolve swiftformat errors and warnings

* updated swiftformat rules

* fix build error

* fix build error

* update rules

* fix build error

* remove commented code

* align comments

* fix spacing
@phantumcode phantumcode requested a review from a team as a code owner October 24, 2024 16:04
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 49.50635% with 358 lines in your changes missing coverage. Please review.

Project coverage is 68.51%. Comparing base (2a3de4b) to head (f944c94).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...Model/Internal/Schema/ModelSchema+Definition.swift 60.71% 44 Missing ⚠️
Amplify/DevMenu/View/IssueReporter.swift 0.00% 27 Missing ⚠️
Amplify/Categories/DataStore/Query/ModelKey.swift 9.09% 20 Missing ⚠️
...Categories/DataStore/Subscribe/MutationEvent.swift 0.00% 20 Missing ⚠️
...plify/Core/Support/Internal/InternalTask+Hub.swift 20.00% 20 Missing ⚠️
...ries/DataStore/Subscribe/MutationEvent+Model.swift 0.00% 15 Missing ⚠️
...WSUnifiedLoggingPlugin/Internal/OSLogWrapper.swift 66.66% 12 Missing ⚠️
...Model/Internal/Schema/ModelField+Association.swift 52.38% 10 Missing ⚠️
Amplify/Core/Support/AmplifyTaskGateway.swift 0.00% 10 Missing ⚠️
.../Categories/Auth/AuthCategory+ClientBehavior.swift 0.00% 9 Missing ⚠️
... and 82 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
- Coverage   69.20%   68.51%   -0.69%     
==========================================
  Files        1087      903     -184     
  Lines       49366    40122    -9244     
==========================================
- Hits        34163    27489    -6674     
+ Misses      15203    12633    -2570     
Flag Coverage Δ
API_plugin_unit_test ?
AWSPluginsCore 70.46% <ø> (+0.10%) ⬆️
Amplify 48.16% <49.50%> (-0.03%) ⬇️
Analytics_plugin_unit_test ?
Auth_plugin_unit_test 80.01% <ø> (-0.10%) ⬇️
DataStore_plugin_unit_test 83.57% <ø> (+0.26%) ⬆️
Geo_plugin_unit_test 75.95% <ø> (+1.08%) ⬆️
Logging_plugin_unit_test ?
Predictions_plugin_unit_test 35.38% <ø> (-0.12%) ⬇️
PushNotifications_plugin_unit_test 88.76% <ø> (+0.32%) ⬆️
Storage_plugin_unit_test ?
unit_tests 68.51% <49.50%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants