Skip to content

Conversation

thisisabhash
Copy link
Member

@thisisabhash thisisabhash commented Aug 27, 2025

Issue #

Unit test workflow keeps failing for a few tests.
https://github.com/aws-amplify/amplify-swift/actions/workflows/deploy_unstable.yml

Description

Increasing timeouts on following tests which keep failing on CI/CD but pass on local machines.

AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingMonitorTests.swift
- testDelegateIsInvokedOnInterval()

AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift
- testConsumeFailureSendsHubEvent()

AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift
- func testLoadPersistableTasks()
- func testPrepareForBackground()

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner August 27, 2025 18:05
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.93%. Comparing base (1d60201) to head (3008d01).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4046      +/-   ##
==========================================
+ Coverage   67.80%   67.93%   +0.13%     
==========================================
  Files        1129     1129              
  Lines       52482    52482              
==========================================
+ Hits        35583    35656      +73     
+ Misses      16899    16826      -73     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (ø)
AWSPluginsCore 69.25% <ø> (ø)
Amplify 47.93% <ø> (ø)
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.63% <ø> (-0.02%) ⬇️
DataStore_plugin_unit_test 84.19% <ø> (+0.84%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 65.27% <ø> (ø)
Predictions_plugin_unit_test 34.77% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 79.39% <ø> (ø)
unit_tests 67.93% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 merged commit ac7eeae into main Aug 27, 2025
94 checks passed
@harsh62 harsh62 deleted the chore/fix-flaky-unit-tests branch August 27, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants