Skip to content

chore(build): increase timeout on flaky unit tests #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

chore(build): increase timeout on flaky unit tests #4046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...gins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingMonitorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/// Then: the delegate is autoamtically invoked
func testDelegateIsInvokedOnInterval() async {
monitor.setAutomaticFlushIntervals()
await fulfillment(of: [invokedExpectation], timeout: 3)
await fulfillment(of: [invokedExpectation], timeout: 10)

Check failure on line 34 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingMonitorTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / visionOS Tests | AWSCloudWatchLoggingPlugin / visionOS Tests | AWSCloudWatchLoggingPlugin 

    testDelegateIsInvokedOnInterval, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Delegate is invoked".

Check failure on line 34 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingMonitorTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / visionOS Tests | AWSCloudWatchLoggingPlugin / visionOS Tests | AWSCloudWatchLoggingPlugin 

    testDelegateIsInvokedOnInterval, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Delegate is invoked".

Check failure on line 34 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingMonitorTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / visionOS Tests | AWSCloudWatchLoggingPlugin / visionOS Tests | AWSCloudWatchLoggingPlugin 

    testDelegateIsInvokedOnInterval, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Delegate is invoked".
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...ng/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
systemUnderTest.client = mockCloudWatchLogClient
systemUnderTest.enable()
try await systemUnderTest.flushLogs()
await fulfillment(of: [hubEventExpectation], timeout: 2)
await fulfillment(of: [hubEventExpectation], timeout: 10)

Check failure on line 72 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / macOS Tests | AWSCloudWatchLoggingPlugin / macOS Tests | AWSCloudWatchLoggingPlugin 

    testConsumeFailureSendsHubEvent, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Should receive the hub event".

Check failure on line 72 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / tvOS Tests | AWSCloudWatchLoggingPlugin / tvOS Tests | AWSCloudWatchLoggingPlugin 

    testConsumeFailureSendsHubEvent, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Should receive the hub event".

Check failure on line 72 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / iOS Tests | AWSCloudWatchLoggingPlugin / iOS Tests | AWSCloudWatchLoggingPlugin 

    testConsumeFailureSendsHubEvent, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Should receive the hub event".

Check failure on line 72 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / watchOS Tests | AWSCloudWatchLoggingPlugin / watchOS Tests | AWSCloudWatchLoggingPlugin 

    testConsumeFailureSendsHubEvent, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Should receive the hub event".

Check failure on line 72 in AmplifyPlugins/Logging/Tests/AWSCloudWatchLoggingPluginTests/AWSCloudWatchLoggingSessionControllerTests.swift

View workflow job for this annotation

GitHub Actions / AWSCloudWatchLoggingPlugin Unit Tests / visionOS Tests | AWSCloudWatchLoggingPlugin / visionOS Tests | AWSCloudWatchLoggingPlugin 

    testConsumeFailureSendsHubEvent, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Should receive the hub event".
}

private func getLogFile() -> URL {
Expand Down
4 changes: 2 additions & 2 deletions .../Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@
}
expectation.fulfill()
}
await fulfillment(of: [expectation], timeout: 5)
await fulfillment(of: [expectation], timeout: 10)

Check failure on line 220 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / iOS Tests | AWSS3StoragePlugin / iOS Tests | AWSS3StoragePlugin 

    testLoadPersistableTasks, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Recover".

Check failure on line 220 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / tvOS Tests | AWSS3StoragePlugin / tvOS Tests | AWSS3StoragePlugin 

    testLoadPersistableTasks, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Recover".

Check failure on line 220 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / watchOS Tests | AWSS3StoragePlugin / watchOS Tests | AWSS3StoragePlugin 

    testLoadPersistableTasks, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Recover".

Check failure on line 220 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / watchOS Tests | AWSS3StoragePlugin / watchOS Tests | AWSS3StoragePlugin 

    testLoadPersistableTasks, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Recover".

Check failure on line 220 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / watchOS Tests | AWSS3StoragePlugin / watchOS Tests | AWSS3StoragePlugin 

    testLoadPersistableTasks, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Recover".
}

/// Given: A DefaultStorageTransferDatabase
Expand All @@ -228,7 +228,7 @@
database.prepareForBackground() {
expectation.fulfill()
}
await fulfillment(of: [expectation], timeout: 5)
await fulfillment(of: [expectation], timeout: 10)

Check failure on line 231 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / watchOS Tests | AWSS3StoragePlugin / watchOS Tests | AWSS3StoragePlugin 

    testPrepareForBackground, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Prepare for Background".

Check failure on line 231 in AmplifyPlugins/Storage/Tests/AWSS3StoragePluginTests/Support/Internal/DefaultStorageTransferDatabaseTests.swift

View workflow job for this annotation

GitHub Actions / AWSS3StoragePlugin Unit Tests / watchOS Tests | AWSS3StoragePlugin / watchOS Tests | AWSS3StoragePlugin 

    testPrepareForBackground, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Prepare for Background".
}

/// Given: The StorageTransferDatabase Type
Expand Down
Loading