chore(deps): Fix transitive dependencies #5796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix-transitive-deps
🦋 Changeset detectedLatest commit: 9dc445b The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebpollman
requested changes
Sep 12, 2024
esauerbo
changed the title
esauerbo
commented
Sep 13, 2024
esauerbo
commented
Sep 13, 2024
| @@ -33,10 +33,12 @@ | |||
| "typecheck": "tsc --noEmit" | |||
| }, | |||
| "dependencies": { | |||
| "@aws-amplify/core": "6.4.0", | |||
There was a problem hiding this comment.
Wasn't sure what version to use, went with 6.4.0 because it's what would be brought in by the latest version of the "aws-amplify": "^6.3.2" peer dep
jordanvn
reviewed
Sep 13, 2024
jordanvn
previously approved these changes
Sep 19, 2024
There was a problem hiding this comment.
This looks good to me. I believe I understand the change, but I would still like to see @calebpollman's remaining question answered
reesscot
previously approved these changes
Sep 20, 2024
| @@ -19,6 +20,12 @@ module.exports = { | |||
| }, | |||
| ignorePatterns: ['dist'], | |||
| rules: { | |||
| 'import/no-extraneous-dependencies': [ | |||
calebpollman
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Smoke tested locally and everything is working as expected, thanks for the hard work here @esauerbo
esauerbo
dismissed stale reviews from calebpollman and reesscot
via
4784042
… fix-transitive-deps
…amplify-ui into fix-transitive-deps
jordanvn
approved these changes
Sep 23, 2024
timngyn
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
import/no-extraneous-dependenciesrule which will error if an import is used that isn't included in the module'spackage.jsonIssue #, if available
Description of how you validated changes
Manually went through each package and removed a dependency and verified that eslint threw an error
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.