Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Fix transitive dependencies #5796
chore(deps): Fix transitive dependencies #5796
Changes from all commits
f8a1494
41254a3
9f3dceb
a95438a
9601199
e036ce9
1787aca
9ce9c8c
13a891b
8740c1e
cf9687a
040c2cf
b1e35ae
4947631
89720de
f6e2aea
c58996b
cf6b613
1c350a1
4e687c1
a198fa8
7b3dc30
f2ecc2b
0ed14d9
f7711c3
27ed51a
754187c
3cffbff
7314a9d
4e6650a
182ad9b
1ef3406
68642bc
61e94c6
dc06f49
4784042
1b80d4a
9dc445b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
"@angular/common"
(and"rxjs"
below) doesn't feel quite right to me. Can you explain why we would remove them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #5796 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're only using
@aws-amplify/core
in the storage package to reference a deprecated type (StorageAccessLevel
), can we manually recreate the type and remove the peer dep? Can be done in a follow upThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah will do this in a followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nce catch!