Cognito auth release service #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow deallocate resources and unbind services
Lead to double binding to service
frankmuellr
added
cognito
|
Thoughts (not a request for change, yet): This would require an explicit call to unbind the service. I wonder if we could do it as part of the user cancelling or finishing the sign-in event. |
rlatapy-luna
force-pushed
the
cognitoAuth_release_service
branch
from
1ad93d2 to
8b2bbfd
Compare
I'm not sure we can be aware of sign-in finish as we are redirect to the app through the deep linking. |
minbi
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to unbind connectionService bound in custom tab before finishing the context used. Avoid this kind of log error:
Activity <App Name> has leaked ServiceConnection <ServiceConnection Name>@438030a8 that was originally bound here