Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito auth release service #615

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Cognito auth release service #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01e7e25
Add release public method
rlatapy-luna Dec 13, 2018
1591728
Fix duplicate client creation
rlatapy-luna Dec 13, 2018
8b2bbfd
Merge remote-tracking branch 'AWS/master' into cognitoAuth_release_se…
rlatapy-luna Jan 18, 2019
5481ef1
Merge branch 'master' into cognitoAuth_release_service
minbi Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ndroid-sdk-cognitoauth/src/main/java/com/amazonaws/mobileconnectors/cognitoauth/Auth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ private Auth(final Context context,
this.signOutRedirectUri = signOutRedirectUri;
this.scopes = scopes;
this.user = new AuthClient(context, this);
this.user = new AuthClient(context, this);
this.user.setUserHandler(userHandler);
this.userPoolId = userPoolId;
this.advancedSecurityDataCollectionFlag = advancedSecurityDataCollectionFlag;
Expand Down Expand Up @@ -655,4 +654,11 @@ public Auth setUsername(final String username) {
this.user.setUsername(username);
return this;
}

/**
* Release resources used by {@link Auth}
*/
public void release() {
this.user.unbindServiceConnection();
}
}
9 changes: 9 additions & 0 deletions ...-sdk-cognitoauth/src/main/java/com/amazonaws/mobileconnectors/cognitoauth/AuthClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,15 @@ public void getTokens(final Uri uri) {
getTokens(uri, userHandler);
}


/**
* Unbind {@link AuthClient#mCustomTabsServiceConnection}
*/
public void unbindServiceConnection() {
if(mCustomTabsServiceConnection != null)
context.unbindService(mCustomTabsServiceConnection);
}

/**
* Internal method to exchange code for tokens.
* <p>
Expand Down