Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::ECR::Repository-ImageScanningConfiguration #245

Closed
autarchprinceps opened this issue Oct 29, 2019 · 15 comments
Closed

AWS::ECR::Repository-ImageScanningConfiguration #245

autarchprinceps opened this issue Oct 29, 2019 · 15 comments
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Milestone

Comments

@autarchprinceps
Copy link

CloudFormation requires the equivalent setting to:
aws ecr create-repository --repository-name name --image-scanning-configuration scanOnPush=true
to enable the automatic image scanning on ECR.

https://docs.aws.amazon.com/en_pv/AmazonECR/latest/userguide/image-scanning.html

ECR is Compute and the expected behaviour is to make the scanOnPush settings configurable through CloudFormation as well. I think what needs to be done is clear.

@whereisaaron
Copy link

Ref: aws/containers-roadmap#552

@RomanCRS
Copy link

Any ETA on this?

@et304383
Copy link

Why isn't CloudFormation a first class citizen like the API when new features are released? Sigh.

@autarchprinceps
Copy link
Author

autarchprinceps commented Apr 14, 2020

Why isn't CloudFormation a first class citizen like the API when new features are released? Sigh.

Yeah, I have asked myself this many times, especially, when it is not something that seems to be very complex, since it is a 1:1 match to the corresponding fields in the API. I've seen several of those cases, and they still take months to be in Cloudformation.
Often terraform is faster than CloudFormation. How can that be?

@1davidmichael
Copy link

I'd like an ETA on this as well. From a feature perspective if it isn't available via CFN it isn't worth us using unless we go the custom resource route, which is a pain.

@ngamradt-turner
Copy link

@1davidmichael I agree, custom resources are for something that is truly custom work, not for adding base-line support of feature that AWS has added.

I have reached out to our TAM team to ask about this specific feature, I would ask that others do the same.

@JonLittleIT
Copy link

Please make this happen faster....

@luiseduardocolon
Copy link
Contributor

I hear you @JonLittleIT :) hopefully we'll have some good news real soon now ...

@mwarkentin
Copy link

Looks like this is available now: aws/containers-roadmap#552 (comment)

@PatMyron
Copy link
Contributor

AWS::ECR::Repository.ImageScanningConfiguration

examples

@sam9191
Copy link

sam9191 commented Feb 22, 2021

ImageScanningConfiguration works but I get a validation error in my template on AWS Console:

        "myRepository": {
            "Type": "AWS::ECR::Repository",
            "Properties": {
                "RepositoryName": "myRepoName",
                "ImageScanningConfiguration": {
                    "scanOnPush": "true"
                }
            }
        }

Here is the error message:

Stack operations on resource myRepository would fail starting from 03/01/2021 as the template has invalid properties. Please refer to the resource documentation to fix the template. Properties validation failed for resource myRepository with message: #/ImageScanningConfiguration: extraneous key [scanOnPush] is not permitted

Is this a bug?
Will my template stop working from 03/01/2021 as the error message says?

@PatMyron
Copy link
Contributor

PatMyron commented Feb 22, 2021

@sam9191
Copy link

sam9191 commented Feb 23, 2021

Yes "ScanOnPush" did it. So should the example in the docs be corrected?
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#aws-resource-ecr-repository--examples

@Vadim-Zenin
Copy link

Hello,
scanOnPush throw
Resource template validation failed for resource Repository as the template has invalid properties. Please refer to the resource documentation to fix the template. Properties validation failed for resource Repository with message: #/ImageScanningConfiguration: extraneous key [scanOnPush] is not permitted

@sam9191
Copy link

sam9191 commented Aug 23, 2022

@Vadim-Zenin try ScanOnPush with capital S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute EC2, ECR, ECS, EKS, Lambda, Batch, Elastic Beanstalk, Serverless Application Repository
Projects
None yet
Development

No branches or pull requests