Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable imageScanOnPush when creating ECR repo #7471

Closed
1 of 2 tasks
pahud opened this issue Apr 21, 2020 · 0 comments · Fixed by #7501
Closed
1 of 2 tasks

enable imageScanOnPush when creating ECR repo #7471

pahud opened this issue Apr 21, 2020 · 0 comments · Fixed by #7501
Assignees
@MrArnoldPalmer
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@pahud
Copy link
Contributor

pahud commented Apr 21, 2020 •
edited
Loading

Amazon ECR has supported the imageScanOnPush capabilities, however, due to the lack of cloudformation support(see aws/containers-roadmap#552 and aws-cloudformation/cloudformation-coverage-roadmap#245), we can't simply enable this feature when we create the Repository resource in AWS CDK aws-ecr construct.

Use Case

To create the ECR repository and enable the scanOnPush configuration at the same time.

Proposed Solution

to support it with AwsCustomResource

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Apr 22, 2020
@pahud pahud mentioned this issue Apr 22, 2020
Merged
5 tasks
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Apr 23, 2020
@MrArnoldPalmer MrArnoldPalmer added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 23, 2020
@mergify mergify bot closed this as completed in #7501 May 3, 2020
mergify bot pushed a commit that referenced this issue May 3, 2020
@pahud
feat(ecr): support imageScanOnPush when creating the repository
9df5486 
Add a new imageScanOnPush property for the new repository creation.

Fix #7471
@winky winky mentioned this issue May 5, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecr): support imageScanOnPush when creating the repository
3 participants
@pahud @MrArnoldPalmer @SomayaB