-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-ecr: support create ECR repository with scanOnPush enabled #4979
Labels
@aws-cdk/aws-ecr
Related to Amazon Elastic Container Registry
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
Comments
pahud
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 12, 2019
Any updates? |
Cfn still doesn't support this out of the box. There is no one on the core team working on the custom resource currently. Add a 👍 to the issue if this is important to you as that helps us to prioritize. PRs are always welcome as well. |
winky
added a commit
to winky/aws-cdk
that referenced
this issue
May 4, 2020
Support scanOnPush option to ecr repository. Cfn still does not support this out of the box, so we use custom resource. Closes aws#4979
I think this Issue can be closed by #7471. |
@winky Yes it's already been shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecr
Related to Amazon Elastic Container Registry
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
The
scanOnPush
is not supported in cloudformation yet. We probably can usecustom-resources
construct lib to enable it when creating the ECR repository.Use Case
It's very helpful if aws-ecr can create the repository with the
scanOnPush
activated.Proposed Solution
As cloudformation has yet to support this in AWS::ECR::Repository, I was thinking mayabe we can implement it with
custom-resources
so we can eventually create the repo like thisor just
However,
custom-resources/lib/aws-custom-resource/runtime
is running on Lambda NodeJS runtime with current AWS SDK VERSION: 2.488.0 while this feature requires aws-sdk-js >= 2.557.0.I think we should enable this before the cloudformation native support but I am not sure what we can do.
Other
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: