Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Cluster Tags #4995

Closed
1 of 2 tasks
Tracked by #6491
pahud opened this issue Nov 13, 2019 · 7 comments · Fixed by #18109
Closed
1 of 2 tasks
Tracked by #6491

[aws-eks] Cluster Tags #4995

pahud opened this issue Nov 13, 2019 · 7 comments · Fixed by #18109
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@pahud
Copy link
Contributor

pahud commented Nov 13, 2019

To create tags with cluster.

Use Case

Amazon EKS support resource tags, however, aws-eks doesn't support it at this moment.
https://docs.aws.amazon.com/eks/latest/userguide/eks-using-tags.html

cloudformation not yet to support it
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-cluster.html

However, API/SDK/CLI support it
https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateCluster.html

Proposed Solution

To provide the tags property in the ICluster interface and implement the cluster tagging in the Cluster class with custom-resources.

Does it make any sense?

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 13, 2019
@eladb
Copy link
Contributor

eladb commented Nov 13, 2019

Yes totally we already use a custom resource to provision the cluster so this should be easy to support

@pahud
Copy link
Contributor Author

pahud commented Nov 13, 2019

@eladb OK Let me try.

Can you help look into this similar issue? #4979

@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 13, 2019
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 13, 2019
@reillykw
Copy link
Contributor

The botocore version supplied by current python lambdas doesn't quite yet support tags with create_cluster function. I gave python3.8 a go, since it was a higher version and still was receiving validation errors. This may need a different layer supplied or just wait for the lambda environment to upgrade.

@eladb eladb added effort/medium Medium work item – several days of effort effort/small Small work item – less than a day of effort and removed effort/medium Medium work item – several days of effort labels Jan 23, 2020
@eladb eladb added the p1 label Mar 9, 2020
@eladb eladb changed the title aws-eks: create cluster with tags EKS: Cluster Tags Jun 24, 2020
@eladb eladb modified the milestone: EKS Developer Preview Jun 24, 2020
@eladb eladb changed the title EKS: Cluster Tags [EKS Feature] Cluster Tags Jun 24, 2020
@eladb eladb added this to the EKS Dev Preview milestone Jul 22, 2020
@eladb eladb assigned iliapolo and unassigned eladb Aug 4, 2020
@iliapolo iliapolo removed this from the EKS Dev Preview milestone Aug 11, 2020
@iliapolo iliapolo changed the title [EKS Feature] Cluster Tags [aws-eks] Cluster Tags Aug 16, 2020
@iliapolo iliapolo added this to the [GA] @aws-cdk/aws-eks milestone Oct 4, 2020
@elgamala
Copy link

elgamala commented Oct 9, 2020

+1: Our customer is waiting for it

@adriantaut
Copy link
Contributor

hey guys, any news on this one so far?

@iliapolo
Copy link
Contributor

iliapolo commented Jan 5, 2021

@adriantaut Hi, this is not currently planned. We will gladly accept a PR though if you are interested.

@iliapolo iliapolo removed their assignment Jun 27, 2021
choryuidentify added a commit to choryuidentify/aws-cdk that referenced this issue Dec 21, 2021
choryuidentify added a commit to choryuidentify/aws-cdk that referenced this issue Dec 21, 2021
choryuidentify added a commit to choryuidentify/aws-cdk that referenced this issue Dec 21, 2021
choryuidentify added a commit to choryuidentify/aws-cdk that referenced this issue Dec 21, 2021
@mergify mergify bot closed this as completed in #18109 Jan 10, 2022
mergify bot pushed a commit that referenced this issue Jan 10, 2022
Fixes #4995


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
Fixes aws#4995


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants