security hardening of service controllers #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijtrip2
force-pushed
the
root-less-image
branch
from
116b07f to
18eaf4d
Compare
jaypipes
reviewed
Jan 6, 2022
jaypipes
approved these changes
Jan 6, 2022
Collaborator
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
👍 from me, great work Vijay!
Contributor
Author
|
note to reviewers: currently working on fixing the failing tests. These are mainly due to old go version/dependencies in test base images |
Contributor
Author
|
Possible fixes for the test failures are in this test-infra PR. aws-controllers-k8s/test-infra#170 |
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-controllers-k8s/community#1112
Description of changes:
public.ecr.aws/eks-distro-build-tooling/eks-distro-minimal-base-nonroot:2021-12-01-1638322424and golang image to1.17.5for building controller imagesdeployment.yamlfiles to runAsUser 1000. This userId was selected as random.v0.16.0By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.