Generate Vpc Endpoint using ACK runtime v0.15.1
#15
Conversation
brycahta
requested review from
jaypipes,
bwagner5 and
RedbackThomson
and removed request for
a-hilaly and
vijtrip2
| VpcEndpoint: | ||
| exceptions: | ||
| terminal_codes: |
There was a problem hiding this comment.
Yes, you are reading that correctly. EC2 api returns both InvalidVpcID.Malformed and InvalidVpcId.Malformed
| func addIDToDeleteRequest(r *resource, | ||
| input *svcsdk.DeleteVpcEndpointsInput) error { | ||
| if r.ko.Status.VPCEndpointID == nil { | ||
| return errors.New("unable to extract VPCEndpointID from resource") |
There was a problem hiding this comment.
might want to make this a package-level var.
There was a problem hiding this comment.
hmm I'm not seeing why, could you help me understand?
Either way-- I'm hoping this code will be short-lived following some updates to code-generator.
|
Release test is failing because after removing aws_account_id, test-helm.sh doesn't have a way of getting or setting the credentials. Fix to this script is incoming |
|
/test ec2-release-test |
| @pytest.fixture(scope="module") | ||
| def ec2_client(): | ||
| return boto3.client("ec2") |
There was a problem hiding this comment.
Btw you can add this fixture to your conftest.py and it can be accessed by every test, by default. See https://github.com/aws-controllers-k8s/s3-controller/blob/main/test/e2e/conftest.py#L46-L52
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, brycahta, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: #489
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.