Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Vpc Endpoint using ACK runtime v0.15.1 #15

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Generate Vpc Endpoint using ACK runtime v0.15.1 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
453f390
generate vpc endpoint
brycahta Oct 5, 2021
eafad36
add vpc endpoints hook for delete
brycahta Oct 5, 2021
590a32d
add vpc endpoint exceptions
brycahta Oct 5, 2021
80b2c8b
add vpc endpoint smoke tests
brycahta Oct 7, 2021
30c156c
apply ack runtime v0.15.1 updates
brycahta Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2021-10-08T18:52:21Z"
build_hash: 385779a205bea50e8762b76bc75cab957cf723b9
go_version: go1.15
build_date: "2021-10-08T20:55:38Z"
build_hash: 4b30ff5578e2f570d1c5b1741f3098be0d78e246
go_version: go1.17
version: v0.15.1
api_directory_checksum: f932597e3f04c589fffc88c5868e584fe3c8c8ce
api_directory_checksum: e860f6435d7aa89d9171eb1e0e42d969a9cd4d84
api_version: v1alpha1
aws_sdk_go_version: v1.37.10
generator_config_info:
file_checksum: f4eaa88d729c475a9e61cbf96c021732a2732fcd
file_checksum: 45f149e5444111a0e7a0a159b47c1ae38adfb0a6
original_file_name: generator.yaml
last_modification:
reason: API generation
23 changes: 21 additions & 2 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ignore:
field_paths:
- CreateVpcEndpointInput.DryRun
- CreateVpcInput.DryRun
- CreateSubnetInput.DryRun
- CreateRouteTableInput.DryRun
Expand Down Expand Up @@ -55,14 +56,22 @@ ignore:
- Volume
- VpcEndpointConnectionNotification
- VpcEndpointServiceConfiguration
- VpcEndpoint
#- VpcEndpoint
#- Vpc
- VpcCidrBlock
- VpcPeeringConnection
- VpnConnectionRoute
- VpnConnection
- VpnGateway

operations:
CreateVpcEndpoint:
output_wrapper_field_path: VpcEndpoint
DeleteVpcEndpoints:
operation_type:
- Delete
resource_name: VpcEndpoint

resources:
Subnet:
exceptions:
Expand All @@ -73,4 +82,14 @@ resources:
exceptions:
terminal_codes:
- InvalidVpcID.Malformed
- InvalidVpcID.NotFound
- InvalidVpcID.NotFound
VpcEndpoint:
exceptions:
terminal_codes:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are reading that correctly. EC2 api returns both InvalidVpcID.Malformed and InvalidVpcId.Malformed

- InvalidVpcId.Malformed
- InvalidVpcId.NotFound
- InvalidServiceName
hooks:
sdk_delete_post_build_request:
template_path: hooks/vpc_endpoint/sdk_delete_post_build_request.go.tpl

196 changes: 116 additions & 80 deletions apis/v1alpha1/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading