Skip to content

adding references to custom resources #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2022
Merged

adding references to custom resources #18

merged 5 commits into from
Sep 12, 2022

Conversation

@dalbhanj
Copy link
Contributor

@dalbhanj dalbhanj commented Sep 9, 2022

Issue #, if available: aws-controllers-k8s/community#1472

Description of changes: Once we add resource reference, emr-containers jobruns can reference virtualcluster custom resources directly. This is more k8s friendly and avoids exporting and importing variables

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and jaypipes September 9, 2022 19:57
a-hilaly
a-hilaly reviewed Sep 9, 2022
View reviewed changes
helm/templates/cluster-role-controller.yaml
name: ack-emrcontainers-controller
namespace: {{ .Release.Namespace }}
{{ end }}
rules:
Copy link
Member

@a-hilaly a-hilaly Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the cause of failing tests in aws-controllers-k8s/code-generator#362 - investigating why this is happening. For now holding all the PRs using the latest version of code-generator

RedbackThomson
RedbackThomson suggested changes Sep 9, 2022
View reviewed changes
@a-hilaly
Copy link
Member

a-hilaly commented Sep 12, 2022

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Sep 12, 2022 •
edited
Loading

Hi @dalbhanj, you will need to publish ack-test-emrcontainers-f020dcf6:latest in the emrcontainers AWS testing account. Ideally provide a script or a makefile so anyone can reproduce tests on there accounts, we have an example here /https://github.com/aws-controllers-k8s/lambda-controller/tree/main/test/e2e/resources/lambda_function

@dalbhanj
Copy link
Contributor Author

dalbhanj commented Sep 12, 2022

/retest

a-hilaly
a-hilaly approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Thanks Peter!

@a-hilaly
Copy link
Member

a-hilaly commented Sep 12, 2022

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, dalbhanj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 0efcdde into aws-controllers-k8s:main Sep 12, 2022
@dalbhanj dalbhanj deleted the add_references branch September 13, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jaypipes jaypipes Awaiting requested review from jaypipes

+1 more reviewer

@RedbackThomson RedbackThomson RedbackThomson requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dalbhanj @a-hilaly @ack-bot @RedbackThomson