Add Region() to ResourceMetadata struct and AWSResourceIdentifiers interface
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
changed the title
Region() to ResourceMetadata struct and AWSResourceIdentifiersRegion() to ResourceMetadata struct and AWSResourceIdentifiers interface
a-hilaly
force-pushed
the
resource-region
branch
from
aae8cf1 to
651443d
Compare
interface Currently when a resource is created without setting a region in the annotations, the controller uses either the namespace annotation or the controller region flag. This causes the controller to miss manage the resource if they are restart with a different region, or if run a second controller using a different region flag. This patch adds a new field to `ResourceMetadata` struct and `AWSResourceIdentifiers` interface store the AWSRegion in which the resource is created/should be managed. This patch also updates the `reconciler.getRegion` method to lookup for a region in the status.ResourceMetadata before trying to get one from the resource/namespace annotations or the controller configuration. Addresses aws-controllers-k8s/community#1220 This patch will also require some changes to the code-generator.
a-hilaly
force-pushed
the
resource-region
branch
from
651443d to
c15a3a8
Compare
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Mar 22, 2022
Follow up to aws-controllers-k8s/runtime#79 This patch modifies the code-generator to generate a `Region` function so that a resource can also satisfy the `Identifiers` interface. This the patch also extends the `setStatusDefaults` so that it correctly populates the `status.ResourceMetadata.Region` with the aws region in which it is created/managed Description of changes: - Add `Region()` method to resourceIdentifiers template. - Modifies `setStatusDefaults` to be able to set the a default region. - Update `runtime_test.go` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a resource is created without setting a region in the
annotations, the controller uses either the namespace annotation or the
controller region flag. This causes the controller to miss manage the
resource if they are restart with a different region, or if run a second
controller using a different region flag.
This patch adds a new field to
ResourceMetadatastruct andAWSResourceIdentifiersinterface to store the AWS region in whichthe resource is created/should be managed. This patch also updates the
reconciler.getRegionmethod to lookup for a region in thestatus.ResourceMetadata before trying to get one from the
resource/namespace annotations or the controller configuration.
Addresses aws-controllers-k8s/community#1220
This patch will also require some changes to the code-generator.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.