Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Karpenter new NTH IAM policies #1145

Merged
merged 21 commits into from
Dec 3, 2022
Merged

feat: Add Karpenter new NTH IAM policies #1145

merged 21 commits into from
Dec 3, 2022

Conversation

FernandoMiguel
Copy link
Contributor

@FernandoMiguel FernandoMiguel commented Nov 8, 2022 •
edited by askulkarni2
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

The next version of Karpenter adds support for NTH: https://github.com/aws/karpenter/pull/2546/files

This PR adds the IAM changes to this module.
A future PR will add the ConfigMap and SET changes, once the release is done, so I can test.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@FernandoMiguel
add nth policies
3169b82 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel
add vars
b658917 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel
remove interpolation
5a24ff7 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel FernandoMiguel mentioned this pull request Nov 8, 2022
Merged
3 tasks
@FernandoMiguel FernandoMiguel changed the title add Karpenter new NTH IAM policies feat: add Karpenter new NTH IAM policies Nov 8, 2022
@FernandoMiguel FernandoMiguel changed the title feat: add Karpenter new NTH IAM policies feat: Add Karpenter new NTH IAM policies Nov 8, 2022
@askulkarni2
Copy link
Contributor

@FernandoMiguel please open an issue. And can we please do 1 PR for the NTH feature when its ready?

@FernandoMiguel
Copy link
Contributor Author

Will do.

@askulkarni2 askulkarni2 marked this pull request as draft November 10, 2022 00:51
@askulkarni2
Copy link
Contributor

Hi @FernandoMiguel Karpenter v0.19.0 has been released! Let's get this PR up-to-date with the required changes. I've documented them in #1175. Please have a look and let me know if I am missing anything.

@FernandoMiguel
Copy link
Contributor Author

@askulkarni2 already have the values.yaml changed locally, so should be easy to test against this branch.
There are a few new IAM policies that I need to add, that were added this week.
Will try to get something tomorrow.
I'll be on call from Friday so I'll be away from eks work, sadly.

@askulkarni2 askulkarni2 mentioned this pull request Nov 17, 2022
Closed
6 tasks
@micbegin micbegin mentioned this pull request Nov 17, 2022
Closed
6 tasks
@FernandoMiguel FernandoMiguel marked this pull request as ready for review November 17, 2022 17:30
@FernandoMiguel
update iam policy
4c698f9 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel
Copy link
Contributor Author

merged @andrewhibbert branch into mine, since they add already all the code for the settings bit

@FernandoMiguel
add var karpenter_sqs_queue_arn
d70aaa6 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel
Copy link
Contributor Author

It's in the locals

@FernandoMiguel FernandoMiguel mentioned this pull request Nov 21, 2022
Closed
@FernandoMiguel
Copy link
Contributor Author

waiting on a review.
thanks

@FernandoMiguel
Copy link
Contributor Author

Hi team,
can I get a new review pls?
thanks

1 similar comment
@FernandoMiguel
Copy link
Contributor Author

Hi team,
can I get a new review pls?
thanks

@bryantbiggs bryantbiggs requested a review from a team as a code owner December 3, 2022 13:27
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test December 3, 2022 13:28 Inactive
@bryantbiggs bryantbiggs merged commit 95b5f71 into aws-ia:main Dec 3, 2022
mikeinton pushed a commit to mikeinton/terraform-aws-eks-blueprints that referenced this pull request Dec 5, 2022
@FernandoMiguel @mikeinton
feat: Add Karpenter new NTH IAM policies (aws-ia#1145)
32557ba 
Co-authored-by: andrewhibbert <a.hibbert@elsevier.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves undefined
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@FernandoMiguel @allamand
feat: Add Karpenter new NTH IAM policies (aws-ia#1145)
52925c3 
Co-authored-by: andrewhibbert <a.hibbert@elsevier.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves undefined
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
@FernandoMiguel @allamand
feat: Add Karpenter new NTH IAM policies (aws-ia#1145)
91fd936 
Co-authored-by: andrewhibbert <a.hibbert@elsevier.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Resolves undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@csantanapr csantanapr Awaiting requested review from csantanapr

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrades for karpenter v0.19.1
4 participants
@FernandoMiguel @askulkarni2 @bryantbiggs @andrewhibbert