-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Native Spot Termination Handling #2546
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
0d241e0
to
530fb08
Compare
acff4cf
to
64a59dc
Compare
5fc53aa
to
f6d781b
Compare
f6d781b
to
2c81fe5
Compare
2c81fe5
to
6819caf
Compare
6819caf
to
563aa44
Compare
🎉 |
now starts the fun bit of me trying to port all these changes to terraform |
here's the 1st part for IAM policies aws-ia/terraform-aws-eks-blueprints#1145 |
Hi ! Does this PR mean that it is no longer recommended (or necessary) to install the aws/aws-node-termination-handler resource ? Thanks! |
Yep. You can continue to use it, if you prefer. |
Is there any new setup for this , I do not see any docs about the new interruption controller, any help if be awesome. |
are there updated docs on how to implement this? The above link goes to a page not found. Also, what is the minimum supported version of karpenter that this was introduced in? |
https://karpenter.sh/v0.30/concepts/deprovisioning/#consolidation |
|
Fixes #702
Description
aws/controllers/nodetemplate
andaws/controllers/interruption
aws/controllers/nodetemplate
is responsible for reconciling the desired state of Karpenter AWS infrastructure with the current stateaws/controllers/nodetemplate
is also responsible for cleaning up the infrastructure when allAWSNodeTemplates
are removedaws/controllers/interruption
is responsible for polling the SQS queue and cordoning and draining instances that it receives notifications for from the SQS queueHow was this change tested?
make test
FOCUS=Interruption make e2etests
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.