fix: Add missing AddTags permission for AWS load balancer controller #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghaering
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Failure
ghaering
changed the title
|
This has been fixed in https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/releases/tag/v1.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow load balancer controller to create tags on ELB.
Motivation and Context
Without the change in this pull request, we could not have load balancers created. According to a colleague, there was a recent change in the AWS APIs related to tagging and load balancers, which is the reason why we need this change.
See for example this for a discussion how it was solved there:
kubernetes-sigs/aws-load-balancer-controller#3046
How was this change tested?
pre-commit run -awith this PRAdditional Notes