update IAM policy template #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
kishorj
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
size/M
Apollorion
reviewed
Feb 10, 2023
Apollorion
reviewed
Feb 10, 2023
Co-authored-by: Joey Stout <joey@apollorion.com>
Co-authored-by: Joey Stout <joey@apollorion.com>
kishorj
added
the
do-not-merge/hold
Codecov ReportBase: 54.07% // Head: 54.07% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## release-2.4 #3046 +/- ##
============================================
Coverage 54.07% 54.07%
============================================
Files 144 144
Lines 8301 8301
============================================
Hits 4489 4489
Misses 3484 3484
Partials 328 328 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
set ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.20, since 2.4 branch uses go 1.19
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
kishorj
removed
the
do-not-merge/hold
eduardoweiland
added a commit
to quantosobra/terraform-aws-eks-lb-controller
that referenced
this pull request
Jul 28, 2023
This is the same fix included upstream kubernetes-sigs/aws-load-balancer-controller#3046
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #2692
Description
This is a cherry-pick of PR #3045 to v2.4 branch.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯