Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin markdown lint in workflows to 3.12.2 #2896

Merged
merged 1 commit into from
Nov 15, 2024
Merged

pin markdown lint in workflows to 3.12.2 #2896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
with:
fetch-depth: 0
- name: Install markdown-link-check
run: npm install -g markdown-link-check
run: npm install -g markdown-link-check@3.12.2

- name: Run markdown-link-check in the developers docs
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/PR-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
echo "MDS=$(git diff --name-only --diff-filter=ACMRTUXB $(git merge-base origin/${{ github.event.pull_request.base.ref }} ${{ github.event.pull_request.head.sha }}) ${{ github.event.pull_request.head.sha }} | grep .md$ | grep -v vendor/ | xargs)" >> $GITHUB_ENV

- name: Install markdown-link-check
run: npm install -g markdown-link-check
run: npm install -g markdown-link-check@3.12.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when do we expect to be able to unpin this?

Copy link
Contributor Author

@vasireddy99 vasireddy99 Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall unpin once the issue is resolved upstream - tcort/markdown-link-check#369. No ETA atm, but this should be fine for now.

if: ${{ env.MDS }}

- name: Run markdown-link-check
Expand Down
2 changes: 1 addition & 1 deletion docs/developers/linux-rpm-demo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ See [AWS Distro for OpenTelemetry documentation](https://aws-otel.github.io/docs
### Install ADOT Collector on ECS EC2
See [AWS Distro for OpenTelemetry documentation](https://aws-otel.github.io/docs/setup/ecs) for detailed information on installing ADOT Collector on ECS.

#### enable debugging log
#### Enable debugging log

add a key value pair into `/opt/aws/aws-otel-collector/etc/extracfg.txt` and restart collector

Expand Down
Loading