Version 3.13.5 seems to break when using config file

[isuftin]

With version 3.13.5, I am unable to get the utility to properly check links.

markdown-link-check-config.json:

{
  "ignorePatterns": [
    {
      "pattern": "^https://my-repo.com/docker/markdown-link-check/compare/(.*)"
    },
    {
      "pattern": "^https://my-repo.com/docker/markdown-link-check/commit/(.*)"
    }
  ]
}

README2.md:

# Markdown Link Check

[[_TOC_]]

## Purpose

I'm a simple [document][mlc_usage]

[mlc_usage]: https://github.com/tcort/markdown-link-check#usage

Example run:

/data $ markdown-link-check --config markdown-link-check-config.json  --verbose  README2.md

FILE: README2.md
/data $ echo $?
1
/data $ markdown-link-check  --verbose  README2.md

FILE: README2.md
  [✓] https://github.com/tcort/markdown-link-check#usage → Status: 200

  1 links checked.
/data $ echo $?
0
/data $

This seems to be a regression from 3.12.x

[isuftin]

Note that this is running in an Alpine Docker container.

/data $ markdown-link-check --version
3.13.5
/data $ cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.19.4
PRETTY_NAME="Alpine Linux v3.19"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
/data $ npm --version
10.9.0
/data $ node --version
v20.18.0

[erikbosch]

I have observed the same issue for https://github.com/eclipse-kuksa/kuksa-databroker project

With config, "silent" failure for 3.13.5, "success" for 3.12.2

erik@debian6:~/kuksa-databroker$ !2865
sudo npm install -g markdown-link-check

added 8 packages, removed 1 package, and changed 69 packages in 5s

18 packages are looking for funding
  run `npm fund` for details
erik@debian6:~/kuksa-databroker$ markdown-link-check --version
3.13.5
erik@debian6:~/kuksa-databroker$ markdown-link-check -c ~/kuksa-actions/check-markdown/config.json -a 403,200 README.md

FILE: README.md
erik@debian6:~/kuksa-databroker$ echo $?
1
erik@debian6:~/kuksa-databroker$ sudo npm install -g markdown-link-check@3.12.2

added 1 package, removed 8 packages, and changed 69 packages in 3s

18 packages are looking for funding
  run `npm fund` for details
erik@debian6:~/kuksa-databroker$ markdown-link-check --version
3.12.2
erik@debian6:~/kuksa-databroker$ markdown-link-check -c ~/kuksa-actions/check-markdown/config.json -a 403,200 README.md

FILE: README.md
  [✓] https://github.com/eclipse-kuksa/kuksa-databroker
 ...

  27 links checked.
erik@debian6:~/kuksa-databroker$ echo $?
0
erik@debian6:~/kuksa-databroker$ 

Without config fail, success

erik@debian6:~/kuksa-databroker$ sudo npm install -g markdown-link-check

added 8 packages, removed 1 package, and changed 69 packages in 8s

18 packages are looking for funding
  run `npm fund` for details
erik@debian6:~/kuksa-databroker$ markdown-link-check --version
3.13.5
erik@debian6:~/kuksa-databroker$ markdown-link-check  -a 403,200 README.md

FILE: README.md
  [✓] https://github.com/eclipse-kuksa/kuksa-databroker
...

  27 links checked.
erik@debian6:~/kuksa-databroker$ echo $?
0
erik@debian6:~/kuksa-databroker$ 

Config file for reference

{
    "ignorePatterns": [
      {
        "pattern": "^#"
      },
      {
        "pattern": "%"
      }
    ]
}

[MikeMcC399]

With markdown-link-check@3.13.6 and a package.json script

  check:markdown
    find *.md docs/*.md -print0 | xargs -0 -n1 markdown-link-check -c md-linkcheck.json

I just get shown the filenames, with no checking

FILE: CHANGELOG.md

FILE: CODE_OF_CONDUCT.md

FILE: CONTRIBUTING.md

FILE: LICENSE.md

FILE: README.md

FILE: docs/MAINTENANCE.md

If I remove the config file -c md-linkcheck.json it all works fine and each hyperlink is listed in the logs.

The config file is the following and it seems these exceptions aren't needed anymore:

{
    "httpHeaders": [
        {
            "urls": [
                "https://github.com/",
                "https://guides.github.com/",
                "https://docs.github.com/",
                "https://help.github.com/",
                "https://support.github.com"
            ],
            "headers": {
                "Accept-Encoding": "zstd, br, gzip, deflate"
            }
        }
    ]
}

• See also 403 for github.com because it blocks requests without --compressed curl flag #201

[emdneto]

Facing same issue here in OpenTelemetry Python https://github.com/open-telemetry/opentelemetry-python/actions/runs/11709458753/job/32613721323?pr=4251

[smainil]

to me the issue is here

markdown-link-check/markdown-link-check

Line 291 in d090c91

opts.reporters = config.reporters;

if no reporters parameter is set at command line, it's the default reporter that will be used

markdown-link-check/markdown-link-check

Line 216 in d090c91

input.opts.reporters = program.opts().reporters ?? [ reporters.default ];

but next if we define a config file the reporters are retrieved from the config file and if none is defined, the default reporter set at the beginning is replaced by undefined

[nvuillam]

I have the same problem with MegaLinter :(

[markdown-link-check] command: ['markdown-link-check', '--quiet', '-c', '/action/lib/.automation/.markdown-link-check.json', 'markdown_good_1.md', 'markdown_good_2.md']
[markdown-link-check] CWD: /tmp/lint/.automation/test/markdown
[markdown-link-check] result: 1 

https://github.com/oxsecurity/megalinter/actions/runs/11750534244/job/32738969615?pr=4228