Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.13.5 does not run (docker) #370

Closed
malcolmdimeglio opened this issue Nov 5, 2024 · 4 comments
Closed

Version 3.13.5 does not run (docker) #370

malcolmdimeglio opened this issue Nov 5, 2024 · 4 comments

Comments

@malcolmdimeglio
Copy link

Hi all!

I have been using this repo for some time now and integrated it to my azure pipelines.

I have been running the following command successfully for months:
find . -type f -name \*.md -not -path "./build/*" -not -path "./myFolder/*" -not -path "./\.*/*" -exec docker run --rm -i -v "$(pwd):/tmp:ro" -w /tmp ghcr.io/tcort/markdown-link-check:latest --alive 203 {} +

However it appears that today the stable version gets me the following:
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "markdown-link-check": executable file not found in $PATH: unknown.

The command I am using hasn't changed since it was working last. Anyone knows what's going on here? Am I missing something?

Thanks for you help!

@malcolmdimeglio malcolmdimeglio changed the title Version 3.13.5 does not run Version 3.13.5 does not run (docker) Nov 5, 2024
TylerHelmuth added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Nov 6, 2024
#### Description
the changelog workflow has started failing, likely due to regressions in
the tool's latest release. Pinning until fixed

#### Link to tracking issue
probably related to
- tcort/markdown-link-check#369
- tcort/markdown-link-check#370
@MikeMcC399
Copy link

@malcolmdimeglio

In an effort to work around another issue, markdown-link-check was moved to a sub-directory bin.

The issue with the Docker image is also reproducible using the exact instructions from https://github.com/tcort/markdown-link-check/blob/master/README.md#run-using-docker

git clone https://github.com/tcort/markdown-link-check
cd markdown-link-check
docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/README.md
$ docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:stable /tmp/README.md
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "markdown-link-check": executable file not found in $PATH: unknown.

Workarounds

  1. Pin to previous working version, for example

    docker run -v ${PWD}:/tmp:ro --rm -i ghcr.io/tcort/markdown-link-check:3.12.2 /tmp/README.md
  2. Run markdown-link-check from moved location

    docker run -v ${PWD}:/tmp:ro --rm -i --entrypoint bin/markdown-link-check ghcr.io/tcort/markdown-link-check:3.13.5 /tmp/README.md

@malcolmdimeglio
Copy link
Author

I ended up pinning it to the version 3.12.2 and that solved my issue.

Is the new entry point the new expected behavior or will it eventually change/revert back to what it was before? Just asking to know if I should just start pinning my versions or if I can just change the --entrypoint and keep the stable tag

Thanks for the explanation though!

@MikeMcC399
Copy link

@malcolmdimeglio

I ended up pinning it to the version 3.12.2 and that solved my issue.

Good!

Is the new entry point the new expected behavior or will it eventually change/revert back to what it was before? Just asking to know if I should just start pinning my versions or if I can just change the --entrypoint and keep the stable tag

@tcort
Copy link
Owner

tcort commented Nov 6, 2024

I'll move the script back to its original entry point.

@tcort tcort closed this as completed in 22af5b6 Nov 6, 2024
michael-burt pushed a commit to michael-burt/opentelemetry-collector-contrib that referenced this issue Nov 7, 2024
#### Description
the changelog workflow has started failing, likely due to regressions in
the tool's latest release. Pinning until fixed

#### Link to tracking issue
probably related to
- tcort/markdown-link-check#369
- tcort/markdown-link-check#370
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
#### Description
the changelog workflow has started failing, likely due to regressions in
the tool's latest release. Pinning until fixed

#### Link to tracking issue
probably related to
- tcort/markdown-link-check#369
- tcort/markdown-link-check#370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants