Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated semantic attributes to fix the breaking change from OTEL 1.33 #636

Closed
wants to merge 0 commits into from

Conversation

bjrara
Copy link
Member

@bjrara bjrara commented Dec 8, 2023

Issue

In the latest OTEL java SDK, it removes some semantic attributes Pulse uses to generate RemoteService and RemoteOperation. Once the SDK is released, our customers will see all their HTTP metrics becomes Unknown.

Upstream http PR:
open-telemetry/opentelemetry-java-instrumentation#9968

Description of changes

Replace deprecated attributes with new attributes.

The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us.

open-telemetry/opentelemetry-java-contrib#1050
open-telemetry/opentelemetry-java-contrib#1070

Warning

Please DON'T merge this PR until OTEL 1.33 is integrated.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bjrara bjrara requested a review from a team as a code owner December 8, 2023 01:20
@bjrara bjrara changed the title Replace deprecated semantic attributes to fix the breaking change from OTEL semantic attributes Replace deprecated semantic attributes to fix the breaking change from OTEL 1.33 Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (7b7b390) 50.73%.
Report is 185 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials ⚠️
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing ⚠️
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing ⚠️
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing ⚠️
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials ⚠️
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials ⚠️
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials ⚠️
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #636       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will click approve after the comments and build failures addressed. Thx

@bjrara
Copy link
Member Author

bjrara commented Dec 8, 2023

LGTM! will click approve after the comments and build failures addressed. Thx

Thanks for the review. The build includes AppSignals contract testing, it will keep failing until 1.33 is released and integrated with ADOT.

@bjrara
Copy link
Member Author

bjrara commented Dec 8, 2023

The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us.

open-telemetry/opentelemetry-java-contrib#1050
open-telemetry/opentelemetry-java-contrib#1070

Copy link

This PR is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants