-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated semantic attributes to fix the breaking change from OTEL 1.33 #636
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
=============================================
- Coverage 85.71% 50.73% -34.99%
- Complexity 19 264 +245
=============================================
Files 3 39 +36
Lines 49 1301 +1252
Branches 5 141 +136
=============================================
+ Hits 42 660 +618
- Misses 3 609 +606
- Partials 4 32 +28 ☔ View full report in Codecov by Sentry. |
.../java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! will click approve after the comments and build failures addressed. Thx
Thanks for the review. The build includes AppSignals contract testing, it will keep failing until 1.33 is released and integrated with ADOT. |
The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us. open-telemetry/opentelemetry-java-contrib#1050 |
20f002e
to
3d2f68c
Compare
This PR is stale because it has been open 60 days with no activity. |
Issue
In the latest OTEL java SDK, it removes some semantic attributes Pulse uses to generate RemoteService and RemoteOperation. Once the SDK is released, our customers will see all their HTTP metrics becomes Unknown.
Upstream http PR:
open-telemetry/opentelemetry-java-instrumentation#9968
Description of changes
Replace deprecated attributes with new attributes.
The same changes will be done in the opentelemetry-java-contrib. In fact, it seems the community will handle that for us.
open-telemetry/opentelemetry-java-contrib#1050
open-telemetry/opentelemetry-java-contrib#1070
Warning
Please DON'T merge this PR until OTEL 1.33 is integrated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.