Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to io.opentelemetry.semconv:opentelemetry-semconv #1050

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

deki
Copy link
Contributor

@deki deki commented Sep 19, 2023

Description:

io.opentelemetry:opentelemetry-semconv was moved to io.opentelemetry.semconv:opentelemetry-semconv and the former is now deprecated as per open-telemetry/opentelemetry-java#5786.

After updating to 1.30.0 I have now both variants in my dependency tree and therefore raising this PR to clean it up.

Existing Issue(s):

#1043

Testing:

Unittest execution

Documentation:

Outstanding items:

@deki deki requested a review from a team September 19, 2023 09:27
@deki deki force-pushed the semconv branch 4 times, most recently from f03404a to 9172e84 Compare September 19, 2023 10:38
Copy link

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the update.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @deki!

@trask trask merged commit 1d14305 into open-telemetry:main Sep 26, 2023
13 checks passed
trask added a commit to trask/opentelemetry-java-contrib that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants