-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate agent daemonsets on windows for container insights and application signals #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agent resources for windows
lisguo
commented
Aug 29, 2024
lisguo
changed the title
Create 2 agent daemonsets for windows for container insights, and application signals
Create separate agent daemonsets on windows for container insights and application signals
Aug 29, 2024
integration-tests/amazon-cloudwatch-observability/validator/resourceCount_linuxonly_test.go
Show resolved
Hide resolved
integration-tests/amazon-cloudwatch-observability/validator/resourceCount_windowslinux_test.go
Show resolved
Hide resolved
mitali-salvi
previously approved these changes
Aug 29, 2024
sky333999
approved these changes
Aug 29, 2024
mitali-salvi
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Currently, kubernetes networking is not supported on windows containers with host networking:
From https://kubernetes.io/docs/concepts/services-networking/windows-networking/
We need host networking to have the agent run as a host process container to retrieve container insights metrics from HCS (Host Compute Service).
In order to allow container insights and application signals, we need 2 daemonsets for windows. One running as a host process container, and another that is not.
This PR introduces a a new daemonset specifically for container insights
cloudwatch-agent-windows-container-insights
, and the currentcloudwatch-agent-windows
will be used for application signals.This PR also addressing missing cluster name in the windows configs
Testing
Ran helm template:
Pods:
services
AmazonCloudWatchAgent resources
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.