Fixing integration tests for EKS add-on with the change to separate Container Insights and AppSignals resources in Windows #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
approved these changes
Sep 9, 2024
Paramadon
reviewed
Sep 9, 2024
There was a problem hiding this comment.
I'm guessing the HostNetwork=true for Container insights and the non hostNetwork being used for other functionalities adds these 3 services:
// - cloudwatch-agent-windows-container-insights
// - cloudwatch-agent-windows-container-insights-headless
// - cloudwatch-agent-windows-container-insights-monitoring?
If so I think this pr is good to go 👍
Paramadon
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
As part of this change - aws-observability/helm-charts#90 separate K8s resources are being created with HostNetwork=true for Container insights and the non hostNetwork being used for other functionalities.
This PR updates the integration tests count post making this change
Run - https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/10775786465
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.