chore: update scripts for ipython 8 compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue aws-samples#9 by adapting the scripts to the changes introduced in ipython 8, which disables the ipython_config.py trick to prevent potential Execution with Unnecessary Privileges. To mitigate this, the commit introduces the installation of an editable install using `pip install -e .` to make modules inside the source available to the notebook. Additionally, the scripts are updated to use systemctl for restarting, aligning with the changes in the latest SageMaker instances. Fixes aws-samples#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #9 by adapting the scripts to the changes introduced in ipython 8, which disables the ipython_config.py trick to prevent potential Execution with Unnecessary Privileges. To mitigate this, the commit introduces the installation of an editable install using
pip install -e .to make modules inside the source available to the notebook. Additionally, the scripts are updated to use systemctl for restarting, aligning with the changes in the latest SageMaker instances.Fixes #9
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.