Merge branch ' env_files' into dev #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add environment file to api
… and writing to disk
add envfile as task resource and retrieve from s3
retrieve envfiles from s3 concurrently using go routines
this commit initializes the environment files resource when task starts up, and reads the environment variables from those files when containers are created
create envfile task resource
merge from dev and minor logging changes
envfiles: create directory where the envfile will be written
… to disk, close file manually before rename
envfiles: remove sync call since we don't actually need to flush data…
Merge branch 'dev' into env_files
sharanyad
approved these changes
Apr 1, 2020
mssrivas
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merging env_files branch into dev
Implementation details
Testing
New tests cover the changes: N/A
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.