[Windows] refactor stats package to fetch EBS Volume stats for Windows #4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhc123
approved these changes
Jun 27, 2024
xxx0624
reviewed
Jul 1, 2024
mye956
force-pushed
the
feature/ebs-windows
branch
2 times, most recently
from
4179cea to
225bb4b
Compare
Presently, the code path in stats package of the agent, which invokes the CSI Client to fetch volume metrics is limited to Linux platform only. The same code path can be used for Windows as well. This change refactors the existing code to ensure that the EBS volume stats are collected for Windows as well in addition to Linux.
mye956
approved these changes
Jul 13, 2024
xxx0624
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Presently, the code path in
stats packageof the agent, which invokes the CSI Client to fetch volume metrics, is limited to Linux platform only. The same code path can be used for Windows as well.This change refactors the existing code to ensure that the EBS volume stats are collected for Windows as well in addition to Linux.
Implementation details
Refactor the code from Linux specific files to common platform files.
Testing
Using unit and integration tests for Windows and Linux.
New tests cover the changes: N/A
Description for the changelog
refactor stats package to fetch EBS Volume stats for Windows
Does this PR include breaking model changes? If so, Have you added transformation functions?
NoLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.