Feature/ebs windows #4353
Merged
Feature/ebs windows #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
approved these changes
Sep 19, 2024
mye956
force-pushed
the
feature/ebs-windows
branch
from
71b319c to
9ec05c1
Compare
mye956
approved these changes
Sep 19, 2024
Presently, the code path in stats package of the agent, which invokes the CSI Client to fetch volume metrics is limited to Linux platform only. The same code path can be used for Windows as well. This change refactors the existing code to ensure that the EBS volume stats are collected for Windows as well in addition to Linux.
…indows Presently, we were using the empty implementation of the IsBlockDevice method for Windows. In this change, we will add the same. In order to accomplish the same, we use `GetVolumeNameForVolumeMountPointW` Win32 API. Reference: https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getvolumenameforvolumemountpointw We will call the API to fetch the Volume GUID. If the mount path is invalid, this method would fail and therefore, we can be certain that the mount path is not the block device mount path.
This change adds `golang.org/x/sys/windows` dependencies as vendor dependencies.
* Added the first cut of the implementation for the CSIDriver. * Cleaned the branch with unneeded vendor files. --------- Co-authored-by: Saurabh Chakravarty <drsaurab@amazon.com>
mye956
force-pushed
the
feature/ebs-windows
branch
from
9ec05c1 to
4f57f4b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the implementation for EBS Task Attach on Windows.
Implementation details
Three main components have been implemented for Windows. These include
The majority of the implementation was derived from aws-ebs-csi-driver.
Testing
These changes have all been reviewed with each PR. Unit, integration, MACIS and canary testing have all been done on this feature.
New tests cover the changes: yes
Description for the changelog
Add support for EBS Task Attach on Windows
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.