Fix EBS TA Windows static check failures #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuchoe4
force-pushed
the
dev-ebs-windows
branch
2 times, most recently
from
f72443c to
0bcb963
Compare
jiuchoe4
force-pushed
the
dev-ebs-windows
branch
from
0bcb963 to
b14057a
Compare
jiuchoe4
force-pushed
the
dev-ebs-windows
branch
from
b14057a to
b793901
Compare
jiuchoe4
force-pushed
the
dev-ebs-windows
branch
from
73dc62a to
f044fbc
Compare
mye956
approved these changes
Sep 18, 2024
tinnywang
approved these changes
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Static checks for EBS TA Windows feature branch are failing due to a merge conflict in
mount_windows.goandnode_windows.go. This PR fixes this. Additionally, removedecs-agent/csiclient/csi_client_windows_integ_test.go, as this was added during development solely to test staging and unstaging in isolation for Windows environments. We already test this in other tests.Implementation details
Removed unimplemented holder functions from respective files.
Testing
N/A, these functions have already been tested in previous PRs.
New tests cover the changes: N/A
Description for the changelog
Fix static failures for EBS TA Windows
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.