fix(codebuild): badge is not allowed for CodeCommit sources (#6211)

We used to validate that having a badge was forbidden with CodeCommit sources.
CodeBuild has since lifted that restriction, so we need to remove that validation.

Fixes #6205

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

packages/@aws-cdk/aws-codebuild/lib/source.ts

@@ -497,6 +497,7 @@ export interface CodeCommitSourceProps extends GitSourceProps {
  * CodeCommit Source definition for a CodeBuild project.
  */
 class CodeCommitSource extends GitSource {
+  public readonly badgeSupported = true;
   public readonly type = CODECOMMIT_SOURCE_TYPE;
   private readonly repo: codecommit.IRepository;
 

packages/@aws-cdk/aws-codebuild/test/test.codebuild.ts

@@ -1369,7 +1369,7 @@ export = {
 
     interface BadgeValidationTestCase {
       source: codebuild.Source,
-      shouldPassValidation: boolean
+      allowsBadge: boolean
     }
 
     const repo = new codecommit.Repository(stack, 'MyRepo', {
@@ -1378,22 +1378,22 @@ export = {
     const bucket = new s3.Bucket(stack, 'MyBucket');
 
     const cases: BadgeValidationTestCase[] = [
-      { source: new NoSource(), shouldPassValidation: false },
-      { source: new CodePipelineSource(), shouldPassValidation: false },
-      { source: codebuild.Source.codeCommit({ repository: repo }), shouldPassValidation: false },
-      { source: codebuild.Source.s3({ bucket, path: 'path/to/source.zip' }), shouldPassValidation: false },
-      { source: codebuild.Source.gitHub({ owner: 'awslabs', repo: 'aws-cdk' }), shouldPassValidation: true },
-      { source: codebuild.Source.gitHubEnterprise({ httpsCloneUrl: 'url' }), shouldPassValidation: true },
-      { source: codebuild.Source.bitBucket({ owner: 'awslabs', repo: 'aws-cdk' }), shouldPassValidation: true }
+      { source: new NoSource(), allowsBadge: false },
+      { source: new CodePipelineSource(), allowsBadge: false },
+      { source: codebuild.Source.codeCommit({ repository: repo }), allowsBadge: true },
+      { source: codebuild.Source.s3({ bucket, path: 'path/to/source.zip' }), allowsBadge: false },
+      { source: codebuild.Source.gitHub({ owner: 'awslabs', repo: 'aws-cdk' }), allowsBadge: true },
+      { source: codebuild.Source.gitHubEnterprise({ httpsCloneUrl: 'url' }), allowsBadge: true },
+      { source: codebuild.Source.bitBucket({ owner: 'awslabs', repo: 'aws-cdk' }), allowsBadge: true },
     ];
 
     cases.forEach(testCase => {
       const source = testCase.source;
       const validationBlock = () => { new codebuild.Project(stack, `MyProject-${source.type}`, { source, badge: true }); };
-      if (testCase.shouldPassValidation) {
-        test.doesNotThrow(validationBlock, Error, `Badge is not supported for source type ${source.type}`);
+      if (testCase.allowsBadge) {
+        test.doesNotThrow(validationBlock);
       } else {
-        test.throws(validationBlock, Error, `Badge is not supported for source type ${source.type}`);
+        test.throws(validationBlock, /Badge is not supported for source type /);
       }
     });