Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeBuild badge not supported with CodeCommit repositories #6205

Closed
sahilpalvia opened this issue Feb 10, 2020 · 1 comment · Fixed by #6211
Closed

CodeBuild badge not supported with CodeCommit repositories #6205

sahilpalvia opened this issue Feb 10, 2020 · 1 comment · Fixed by #6211
Assignees
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codecommit Related to AWS CodeCommit bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@sahilpalvia
Copy link

Reproduction Steps

const projectProps = {
    projectName: 'BuildProject',
    description: 'Sample build',
    source: codebuild.Source.codeCommit({<REPOSITORY>}),
    role: "<ROLE>",
    badge: true,
    environment: {
        buildImage: codebuild.LinuxBuildImage.AMAZON_LINUX_2_2,
        computeType: ComputeType.SMALL,
        privileged: true
    }
};

const codebuildProject = new codebuild.Project(this, "CodeBuildProject", projectProps);

Error Log

$ cdk list
Badge is not supported for source type CODECOMMIT
Subprocess exited with error 1

Environment

  • CLI Version : 1.23.0 (build 01f326e)
  • Framework Version: 1.22.0
  • OS : MacOS High Sierra
  • Language : Typescript

Other


This is 🐛 Bug Report

@sahilpalvia sahilpalvia added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2020
@SomayaB SomayaB added @aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codecommit Related to AWS CodeCommit labels Feb 10, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Feb 10, 2020
We used to validate that having a badge was forbidden with CodeCommit sources.
CodeBuild has since lifted that restriction, so we need to remove that validation.

Fixes aws#6205
@skinny85
Copy link
Contributor

Thanks for reporting the issue @sahilpalvia . Fix is in #6211.

@mergify mergify bot closed this as completed in #6211 Feb 12, 2020
mergify bot added a commit that referenced this issue Feb 12, 2020
We used to validate that having a badge was forbidden with CodeCommit sources.
CodeBuild has since lifted that restriction, so we need to remove that validation.

Fixes #6205

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codecommit Related to AWS CodeCommit bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants