Skip to content

Commit

Permalink
chore(integ): fix regression suite failures (#16226)
Browse files Browse the repository at this point in the history
Follow up to #16216

We need to apply a patch for the regression suite to pass because its running the older tests which still make the wrong assertion. 

See `NOTES.md` for more details. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
iliapolo authored Aug 25, 2021
1 parent b1d69d7 commit 5812340
Show file tree
Hide file tree
Showing 2 changed files with 664 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
This [PR](https://github.com/aws/aws-cdk/pull/16205) added a node version check to our CLI courtesy of [`@jsii/check-node/run`](https://github.com/aws/jsii/tree/main/packages/%40jsii/check-node).

This check now causes the CLI to print a deprecation warning that changes the output of the `synth` command. We don't consider this a breaking change since we have no guarantess for CLI output, but it did break some our integ tests (namely `cdk synth`) that used to rely on a specific output.

This patch brings the [fix](https://github.com/aws/aws-cdk/pull/16216) into the regression suite.
Loading

0 comments on commit 5812340

Please sign in to comment.