Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integ): node check breaks cli integ tests #16216

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

iliapolo
Copy link
Contributor

The Node runtime check performed by jsii and introduced in this PR breaks the CLI integration tests since it changes the output of the synth command.

This PR makes it so the test asserts on the content of the template rather than the output of the CLI.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 24, 2021

@iliapolo iliapolo changed the title assert template content instead of cli output chore(integ): node check breaks cli integ tests Aug 24, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 24, 2021
@mergify mergify bot merged commit 27a37ac into master Aug 24, 2021
@mergify mergify bot deleted the epolon/cli-synth-integ branch August 24, 2021 23:17
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7c8c5f6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Aug 25, 2021
Follow up to #16216

We need to apply a patch for the regression suite to pass because its running the older tests which still make the wrong assertion. 

See `NOTES.md` for more details. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
The Node runtime check performed by jsii and introduced in this [PR](aws#16205) breaks the CLI integration tests since it changes the output of the `synth` command. 

This PR makes it so the test asserts on the content of the template rather than the output of the CLI.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Follow up to aws#16216

We need to apply a patch for the regression suite to pass because its running the older tests which still make the wrong assertion. 

See `NOTES.md` for more details. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
The Node runtime check performed by jsii and introduced in this [PR](aws#16205) breaks the CLI integration tests since it changes the output of the `synth` command. 

This PR makes it so the test asserts on the content of the template rather than the output of the CLI.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
Follow up to aws#16216

We need to apply a patch for the regression suite to pass because its running the older tests which still make the wrong assertion. 

See `NOTES.md` for more details. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
The Node runtime check performed by jsii and introduced in this [PR](aws#16205) breaks the CLI integration tests since it changes the output of the `synth` command. 

This PR makes it so the test asserts on the content of the template rather than the output of the CLI.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Follow up to aws#16216

We need to apply a patch for the regression suite to pass because its running the older tests which still make the wrong assertion. 

See `NOTES.md` for more details. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants