Skip to content

Commit

Permalink
Correctly account for CDK::Metadata resource in cdk diff` (#435)
Browse files Browse the repository at this point in the history
The arguments to the diff function were passed incorrectly, resulting in
the version tracking information not being forwarded correctly to
synthesizeTemplate.

Fixes #422
  • Loading branch information
RomainMuller authored Jul 30, 2018
1 parent 4689f7f commit 5a1a277
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/aws-cdk/bin/cdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ async function initCommandLine() {
}

async function main(command: string, args: any): Promise<number | string | {} | void> {
const toolkitStackName = completeConfig().get(['toolkitStackName']) || DEFAULT_TOOLKIT_STACK_NAME;
const trackVersions = completeConfig().get(['versionReporting']);
const toolkitStackName: string = completeConfig().get(['toolkitStackName']) || DEFAULT_TOOLKIT_STACK_NAME;
const trackVersions: boolean = completeConfig().get(['versionReporting']);

args.STACKS = args.STACKS || [];
args.ENVIRONMENTS = args.ENVIRONMENTS || [];
Expand All @@ -180,7 +180,7 @@ async function initCommandLine() {
return await cliList({ long: args.long });

case 'diff':
return await diffStack(await findStack(args.STACK), args.template);
return await diffStack(await findStack(args.STACK), trackVersions, args.template);

case 'bootstrap':
return await cliBootstrap(args.ENVIRONMENTS, toolkitStackName);
Expand Down

0 comments on commit 5a1a277

Please sign in to comment.